Add missing command.xml and remove unused packages #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
changed the title
|
Friendly ping @eko if you could take a look at this. |
eko
approved these changes
Sep 14, 2020
|
All good to me, thank you for your contribution |
|
Thank you for the quick reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed to upload the
command.xmlfile 🤦♂️ in #76EDIT:
I've also removed
laminas/laminas-servicemanagerthat was added in #20 long time ago and I guess that was fixed. I haven't seen any reference in the code toLaminas\ServiceManagerorZend\ServiceManager. Andlaminas/laminas-httpthat was added in 2264161, but I haven't seen any reference either.