add with-expect-call2 that allows unordered calls #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also restructures how the lib works completely to make it more extensible and clean. The new version allows unordered mock calls and can allow for multiple calls of the same fn in any order. Currently the lib is locked into ordered calls. Requiring ordered calls could be added to this POC. So far :do :more, and :once are supported. Arg matching also works as the previous one. Need to add a post-run check to make sure the mocks are all called. This should be as easy as checking the number of calls on each of the mocks.
kkrausse
commented
Jan 27, 2022
| {:mocked-var `(resolve (quote ~fname)) | ||
| :args args | ||
| :body-fn `(fn ~'do-body [] | ||
| ~@body) |
There was a problem hiding this comment.
Suggested change
| ~@body) | |
| (match (into [] args#) | |
| ~args ~@body)) |
so free variables are matched with args and usable in the body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC from noticing restrictions of expect-call, not ready for "production".
Restructures how the lib works completely to make it more
extensible and clean. The new version allows unordered mock calls and
can allow for multiple calls of the same fn in any order. Currently the
lib is locked into ordered calls. Requiring ordered calls could be added
to this POC. So far :do :more, and :once are supported. Arg matching
also works as the previous one.
Need to add a post-run check to make sure the mocks are all called.
This should be as easy as checking the number of calls on each of the mocks.
Needs testing