Merge pull request #8 from ej4/calculate-points

Fix #4 by calculating points in a single query
ej4 · Mar 29, 2017 · 905e8eb · 905e8eb
2 parents 447cd23 + 21c0e52
commit 905e8eb
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/merit/models/active_record/merit/score.rb b/lib/merit/models/active_record/merit/score.rb
@@ -7,7 +7,9 @@ class Score < ActiveRecord::Base
              class_name: 'Merit::Score::Point'
 
     def points
-      score_points.group(:score_id).sum(:num_points).values.first || 0
+      score_points.select('COALESCE(SUM(num_points), 0) AS num_points')
+                  .first
+                  .num_points
     end
 
     class Point < ActiveRecord::Base