Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RowIterator): add Count method #529

Merged
merged 1 commit into from
Aug 20, 2024
Merged

feat(RowIterator): add Count method #529

merged 1 commit into from
Aug 20, 2024

Conversation

ngalaiko
Copy link
Contributor

@ngalaiko ngalaiko commented Aug 20, 2024 •
edited
Loading

in saga-alerts we need to fetch total number of rows for pagination.

I'd like to expose rows count for that, instead of making an additional query.

@ngalaiko
feat(RowIterator): add Count method
a2b864e 
Useful when implementing Pagination with Total count.
@ngalaiko ngalaiko marked this pull request as ready for review August 20, 2024 07:51
@ngalaiko ngalaiko requested review from odsod, thall and a team as code owners August 20, 2024 07:51
odsod
odsod approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@odsod odsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngalaiko ngalaiko merged commit 556d550 into master Aug 20, 2024
1 check passed
@ngalaiko ngalaiko deleted the total-count branch August 20, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odsod odsod odsod approved these changes

@thall thall Awaiting requested review from thall thall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngalaiko @odsod