Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETOS must understand exit codes from the test command #49

Merged
merged 13 commits into from
Jul 8, 2024

Conversation

andmat900
Copy link
Contributor

Applicable Issues

Description of the Change

This change adds the possibility to specify custom verdicts in a test runner (file given as env var $VERDICT_RULE_FILE), which is essentially a mapping of test framework exit codes to ETOS verdicts.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Andrei Matveyeu, [email protected]

@andmat900 andmat900 requested a review from a team as a code owner May 27, 2024 11:30
@andmat900 andmat900 requested review from t-persson and fredjn and removed request for a team May 27, 2024 11:30
@andmat900 andmat900 force-pushed the 20240522_exit_codes branch from 7299891 to b3e5009 Compare May 27, 2024 11:30
@andmat900 andmat900 force-pushed the 20240522_exit_codes branch from b3e5009 to e54b84a Compare May 27, 2024 11:32
Copy link
Member

@fredjn fredjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typehints and docstring updates.

src/etos_test_runner/lib/testrunner.py Show resolved Hide resolved
src/etos_test_runner/lib/testrunner.py Outdated Show resolved Hide resolved
src/etos_test_runner/lib/testrunner.py Outdated Show resolved Hide resolved
src/etos_test_runner/lib/testrunner.py Outdated Show resolved Hide resolved
src/etos_test_runner/lib/testrunner.py Show resolved Hide resolved
src/etos_test_runner/lib/executor.py Show resolved Hide resolved
@andmat900 andmat900 force-pushed the 20240522_exit_codes branch from c061d03 to 5c7f0bc Compare May 30, 2024 10:51
fredjn
fredjn previously approved these changes Jun 12, 2024
Copy link
Member

@fredjn fredjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Tobias will have the final say.

@andmat900 andmat900 force-pushed the 20240522_exit_codes branch from 6a075c2 to 4742fb4 Compare June 13, 2024 12:36
@andmat900 andmat900 requested a review from t-persson July 8, 2024 08:15
@andmat900 andmat900 merged commit 2da272a into eiffel-community:main Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants