Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suite runner configmap #29

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

eiffel-community/etos#197
eiffel-community/etos-suite-runner#47

Description of the Change

Remove the suite runner and log listener versions from the suite starter. We shall now use the ones set in the etos suite runner repositor.

Alternate Designs

I decided on defining the ESR manifest in the etos repository instead of here. This is because I envision difficulties in selecting release versions if we have it in this repository. For each release we would have to lock versions in this repository first and then lock that version in the etos repository instead of just locking the versions in the etos repository.

Benefits

Allows the suite runner to have CI that is not dependent on the suite starter repository.

Possible Drawbacks

None really

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

@t-persson t-persson requested a review from a team as a code owner November 27, 2023 06:54
@t-persson t-persson requested review from fredjn and removed request for a team November 27, 2023 06:54
@t-persson t-persson merged commit e3cd2e9 into eiffel-community:main Nov 27, 2023
3 checks passed
@t-persson t-persson deleted the remove-manifest branch November 27, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants