Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates on neutron energy resolution fitting #34

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Conversation

sebouh137
Copy link
Contributor

Briefly, what does this PR introduce?

  • refactored the definitions for correciton factors w and s:

    • was Ecorr=s*(E_Ecal/w+E_Hcal), changed to Ecorr=s*(E_Ecal+E_Hcal*w)
  • also removed constant term from the energy res fit

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes. See above

@sebouh137 sebouh137 marked this pull request as ready for review September 11, 2024 19:48
@sebouh137 sebouh137 merged commit 18891db into master Sep 11, 2024
2 checks passed
@sebouh137 sebouh137 deleted the neutron_fit branch September 11, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant