Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the neutron benchmark plots #27

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Update the neutron benchmark plots #27

merged 7 commits into from
Sep 4, 2024

Conversation

sebouh137
Copy link
Contributor

@sebouh137 sebouh137 commented Aug 27, 2024

Briefly, what does this PR introduce?

changes the fit used for the neutron energy corrections.

E_corr=(E_Hcal+E_Ecal/w)*s, where E_corr is the corrected energy, E_Hcal is the sum of the clusters in the Hcal, and E_Ecal is defined analogously; w is chosen to minimize the ratio of the sigma/mu of the E_Hcal+E_Ecal/w distribution, and s is a scale factor for the overall energy (determined such that the mu of the (E_Hcal+E_Ecal/w)*s distribution matches the generated neutron energy for a particular range in eta.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: minor changes

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes.

@sebouh137 sebouh137 marked this pull request as ready for review August 27, 2024 20:10
@sebouh137 sebouh137 merged commit 9a878fb into master Sep 4, 2024
2 checks passed
@sebouh137 sebouh137 deleted the sebouh137-patch-2 branch September 4, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant