Semi-coherent zdc benchmark #18
Conversation
|
@JiaJunHuang120000 have you tested this? I'm getting an error in abconv, also it's on CI: |
The problem seems to be due to the BeAGLE file on S3/xrdroot. It is an older BeAGLE file. If we generate a BeAGLE file ourselves locally, convert it to HepMC format, and then run abconv, everything works fine. The only eA BeAGLE file we can find on S3/xrdroot is this one: Are there any other ones available? Or can we have write permission to upload some BeAGLE files that we generated? |
|
@bschmookler Wild idea: I assume we have beagle installed in the container. Could you script hepmc3 generation into the benchmark? |
|
I don't see it in |
|
Okay, I now remember. We can't get beagle in the container if it depends on fluka. Can you share your file then? I can get it onto XRootD myself. |
|
Hi, |
There was a problem hiding this comment.
Using textual representation of HepMC3 is not a good idea. Please, re-write this using
import HepMC3There was a problem hiding this comment.
Is the module install inside ./eic-shell? I receive an error while importing ModuleNotFoundError: No module named 'HepMC3'.
There was a problem hiding this comment.
Oh, looks like it's import pyHepMC3
There was a problem hiding this comment.
Hi,
Can we merge this branch first now that and changes have been settle, and later on we can modify the for using the module?
There was a problem hiding this comment.
@JiaJunHuang120000 Any follow up on this?
Briefly, what does this PR introduce?
Semi-coherent events analysis for the zdc lyso.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.