Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): rm unused lcg workflow #682

Merged
merged 1 commit into from
Mar 24, 2024
Merged

fix(ci): rm unused lcg workflow #682

merged 1 commit into from
Mar 24, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR removes the unused LCG workflow. While using a standard environment like LCG is a nice idea, LCG runs too far behind the releases of DD4hep. We routinely contribute changes to DD4hep and want to use them sooner than 2 years later when they become available in LCG.

What kind of change does this PR introduce?

  • Bug fix (issue: unused code)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No. Workflow was already disabled.

@wdconinc wdconinc enabled auto-merge March 24, 2024 19:19
@wdconinc wdconinc requested review from veprbl, kkauder and Chao1009 March 24, 2024 19:20
@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Mar 24, 2024
@wdconinc wdconinc added this pull request to the merge queue Mar 24, 2024
Merged via the queue into main with commit dc00fc3 Mar 24, 2024
77 checks passed
@wdconinc wdconinc deleted the ci-rm-linux-lcg branch March 24, 2024 23:11
wdconinc added a commit that referenced this pull request Mar 25, 2024
### Briefly, what does this PR introduce?
This PR removes the unused LCG workflow. While using a standard
environment like LCG is a nice idea, LCG runs too far behind the
releases of DD4hep. We routinely contribute changes to DD4hep and want
to use them sooner than 2 years later when they become available in LCG.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: unused code)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No. Workflow was already disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants