feat: material map generation and validation scripts and pipeline job #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
topic: infrastructure
wdconinc
force-pushed
the
material-map-validation-plots
branch
from
7ffcaac to
f4cfe35
Compare
wdconinc
commented
Mar 22, 2024
wdconinc
force-pushed
the
material-map-validation-plots
branch
from
e4e3bc8 to
5524f5c
Compare
wdconinc
force-pushed
the
material-map-validation-plots
branch
from
5524f5c to
c2275d7
Compare
ShujieL
reviewed
Apr 2, 2024
veprbl
reviewed
Apr 2, 2024
Co-authored-by: Dmitry Kalinkin <[email protected]>
wdconinc
commented
Apr 3, 2024
Closed
ShujieL
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds automatic material map generation and validation (including comparison with what happens if we reuse the previous field map). It runs this in a pipeline job.
All this is based on @ShujieL's scripts in https://github.com/eic/snippets/tree/main/Tracking/material_map. It adds:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.