Remove brycecanyon configurations #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: documentation
|
ip6_arches.yml and ip6_brycecanyon.yml should probably go too as there is no difference in the detector configuration anyway and the beam energy would be better described by a beam energy related suffix. |
Implemented. Thanks! |
8 tasks
wdconinc
approved these changes
Mar 24, 2024
|
I'm queueing this since #679 depends on this. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
…ponents (#679) ### Briefly, what does this PR introduce? Currently, we cannot easily control what is included in the far forward and far backward regions, except by hacking around it like in `configurations/zdc_sipm_on_tile_only.yml`. This is making it less obvious how to add only the required far forward geometry to the Acts material map geometry. This PR modifies the jinja template to allow more fine-grained far forward and far backward control, similar to the other subsystem types (e.g. ecal, hcal, pid). It maintains the default, so just specifying `features:far_forward:default:` will load the former `far_forward.xml`, but `features:far_forward:[ZDC_Crystal_LYSO:, ZDC_SiPMonTile:]` will load only those two subsystems. TODO: - [x] #674 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators @ShujieL ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Removes epic_brycecanyon and upgrades other configurations.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Not expected
Does this PR change default behavior?
No