Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: add CartesianGridUV segmentation class, needed for OuterMPGDBarrel. #693

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

ybedfer
Copy link
Contributor

@ybedfer ybedfer commented Dec 11, 2024

Briefly, what does this PR introduce?

OuterMPGDBarel foresees a UV-readout: CartesianGridUV provides for implementing it.

What kind of change does this PR introduce?

  • Other: New feature.

Does this PR introduce breaking changes? What changes might users need to make to their code?

No change. Only prepares the ground for a later modification of epic.

Does this PR change default behavior?

No.

@ybedfer
Copy link
Contributor Author

ybedfer commented Dec 11, 2024

Nota Bene: I did not know what to write as a when argument. I wrote the same as that of the previous patch: when="@=1.29".

@wdconinc
Copy link
Contributor

The when argument specifies for which versions this is applied. As it is now, is this patch will only be applied for version exactly equal to 1.29. You probably want @=1.30 since the patch is only needed for 1.30 (it will be included in any future release and probably doesn't apply to older releases).

@wdconinc wdconinc merged commit 739db5b into eic:develop Dec 13, 2024
2 checks passed
@wdconinc
Copy link
Contributor

From here it goes into the container itself, https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/1063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants