Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/io/podio: remove unused datamodel_LinkDef.h #1704

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 14, 2025

Briefly, what does this PR introduce?

Removing it as it should be irrelevant for recent PODIO with frames format.
Resolves: #1693

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Not supposed to

Does this PR change default behavior?

No

@veprbl veprbl requested a review from wdconinc January 15, 2025 00:14
@wdconinc
Copy link
Contributor

Minimum JANA2 version update in CMakeLists.txt?

@veprbl
Copy link
Member Author

veprbl commented Jan 15, 2025

Why?

@wdconinc
Copy link
Contributor

Sorry, I meant minimum podio version?

@veprbl
Copy link
Member Author

veprbl commented Jan 15, 2025

I tought the fact that we are using frames is already the threshold, but this is all guesses.

We can't set PODIO requirement low enough without implementing icky logic to support both 0.x.y and 1.x.y. (That is a cmake thing)

wdconinc
wdconinc previously approved these changes Jan 15, 2025
@veprbl veprbl added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 451c246 Jan 15, 2025
85 of 86 checks passed
@veprbl veprbl deleted the pr/rm_linkdef branch January 15, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove src/services/io/podio/datamodel_LinkDef.h
2 participants