ZDC: LYSO + SiPM-on-tile

[sebouh137]

Briefly, what does this PR introduce?

Adds functionality to run HEXPLIT and other algorithms for the reconstruction of clusters in the SiPM-on-tile ZDC. Also increases the dynamic range for the ZDC Ecal (LYSO crystal).

What kind of change does this PR introduce?

• Bug fix (issue #__)
• New feature (issue Reconstruction for the LYSO + SiPM-on-tile ZDC.  #1220 )
• Documentation update
• Other: __

Please check if this PR fulfills the following:

• Tests for the changes have been added
• Documentation has been added / updated
• Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no.

Does this PR change default behavior?

Changes the values of the parameters for the ZDC ECal digitization.

[wdconinc]

I'd already sent to this @Gongzi-Zhang, but looking at https://github.com/eic/EICrecon/blob/sipmzdc/src/algorithms/calorimetry/LogWeightReco.cc that algorithm is already available as https://github.com/eic/EICrecon/blob/sipmzdc/src/algorithms/calorimetry/CalorimeterHitsMerger.h and would be good to reuse.

[wdconinc]

Don't worry about the Eigen/Householder include (only that one). It seems that IWYU has trouble with it. Sometimes it just spends 6 hours going back and forth until the job times out or someone cancels it: https://github.com/eic/EICrecon/actions/runs/7532222215/job/20503403799?pr=1234.

[sebouh137]

Don't worry about the Eigen/Householder include (only that one). It seems that IWYU has trouble with it. Sometimes it just spends 6 hours going back and forth until the job times out or someone cancels it: https://github.com/eic/EICrecon/actions/runs/7532222215/job/20503403799?pr=1234.

@wdconinc , In this case, there is only one other check that my pull request fails. Namely, getting the deployment of the docs. I don't see anything in the logs that is specific to any of the files I have added or changed. Can this pull request be approved without passing the deploy-docs?

[veprbl]

Don't worry about the Eigen/Householder include (only that one). It seems that IWYU has trouble with it. Sometimes it just spends 6 hours going back and forth until the job times out or someone cancels it: https://github.com/eic/EICrecon/actions/runs/7532222215/job/20503403799?pr=1234.

@wdconinc , In this case, there is only one other check that my pull request fails. Namely, getting the deployment of the docs. I don't see anything in the logs that is specific to any of the files I have added or changed. Can this pull request be approved without passing the deploy-docs?

Please ignore that one. I'm working to resolve it in #1245

[veprbl]

Need to sort out the naming convention.

[sebouh137]

Don't worry about the Eigen/Householder include (only that one). It seems that IWYU has trouble with it. Sometimes it just spends 6 hours going back and forth until the job times out or someone cancels it: https://github.com/eic/EICrecon/actions/runs/7532222215/job/20503403799?pr=1234.

@wdconinc , In this case, there is only one other check that my pull request fails. Namely, getting the deployment of the docs. I don't see anything in the logs that is specific to any of the files I have added or changed. Can this pull request be approved without passing the deploy-docs?

Please ignore that one. I'm working to resolve it in #1245

In that case, all of the conversations have been resolved, and all of the other checks have been fulfilled. @wdconinc @veprbl or @nathanwbrei , could you please approve of this pull request?
Thanks,
Sebouh

[nathanwbrei]

Looks good! Since it's been through so many rounds of review at this point I'm just going to approve it