Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert PhotoMultiplierHitDigi to use algorithms:: interface #1219

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR converts the PhotoMultiplierHitDigi algorithm to the algorithms:: interface.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc
Copy link
Contributor Author

@wdconinc wdconinc enabled auto-merge January 12, 2024 21:43
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wdconinc wdconinc added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 2177ca4 Jan 12, 2024
74 of 75 checks passed
@wdconinc wdconinc deleted the algorithms-PhotoMultiplierHitDigi branch January 12, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants