Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Seed charge calculation #1213

Merged
merged 3 commits into from
Jan 11, 2024
Merged

fixed Seed charge calculation #1213

merged 3 commits into from
Jan 11, 2024

Conversation

Jeet-bhai
Copy link
Contributor

Briefly, what does this PR introduce?

This pull request modifies the calculation of the seed charge for real seeding for particles generated off the beam axis.

The diagram below shows the proposed change

Screenshot 2024-01-10 at 3 03 59 PM

Here is some statistics to validate this request:
N=10k events, muon with eta -4 to 4, and momentum 0.5 to 20 GeV

Negative muon at (0,0,0)
Total seeds: 25774
Wrong charge seeds (pre-fix): 301 (1.2%)
Wrong charge seeds (post-fix): 224 (0.87%)

Negative muon at (1,0,0) mm
Total seeds: 25521
Wrong charge seeds(pre-fix): 5407 (21.1%)
Wrong charge seeds(post-fix): 230 (0.9%)

Positive muon at (1,0,0) mm
Total seeds: 27688
Wrong charge seeds(pre-fix): 5376 (19.4%)
Wrong charge seeds(post-fix): 368 (1.3%)

This shows that the results are stable for particle generated at z=0.
for particles generated off the beam axis, the results improve significantly for both positive and negative muon.

What kind of change does this PR introduce?

  • [ X] Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • [x ] Tests for the changes have been added
  • Documentation has been added / updated
  • [ x] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

none

Does this PR change default behavior?

yes, for real seeded tracking

@Jeet-bhai Jeet-bhai requested a review from osbornjd January 10, 2024 21:13
@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Jan 10, 2024
Copy link
Contributor

@osbornjd osbornjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have no comments

@osbornjd osbornjd added this pull request to the merge queue Jan 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2024
@bschmookler bschmookler added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit 417daff Jan 11, 2024
73 checks passed
@bschmookler bschmookler deleted the seed_charge branch January 11, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants