Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate ParticlesWithPID_factory to JOmniFactory #1178

Merged
merged 3 commits into from
Dec 7, 2023
Merged

feat: migrate ParticlesWithPID_factory to JOmniFactory #1178

merged 3 commits into from
Dec 7, 2023

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Dec 6, 2023

Briefly, what does this PR introduce?

This migrates the ParticlesWithPID_factory to JOmniFactory. There are no major issues here, but of note:

  • the algorithm now returns tuple of unique_ptrs instead of struct,
  • the algorithm now takes a single CherenkovParticleIDCollection as third argument, instead of a vector of them (one for each Cherenkov detector); this functionality can be restored if needed, or a separate factory can merge the collections once we have pfRICH and DIRC ParticleID collections,
  • after defining the ParameterRefs, the parameters of this algorithm are now parsed by JANA.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: PID Relates to PID reconstruction label Dec 6, 2023
@wdconinc wdconinc mentioned this pull request Dec 6, 2023
Closed
23 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Capybara summary for PR 1178

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 7, 2023

No diffs.

@wdconinc wdconinc marked this pull request as ready for review December 7, 2023 00:47
@wdconinc wdconinc enabled auto-merge December 7, 2023 00:55
@wdconinc wdconinc added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit d65783d Dec 7, 2023
67 checks passed
@wdconinc wdconinc deleted the particles-with-pid-factory-to-omni-factory branch December 7, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-dilks c-dilks c-dilks approved these changes

@veprbl veprbl Awaiting requested review from veprbl

@nathanwbrei nathanwbrei Awaiting requested review from nathanwbrei

Assignees
No one assigned
Labels
topic: PID Relates to PID reconstruction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdconinc @c-dilks