-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate PhotoMultiplierDigi_factory to JOmniFactory #1177
Conversation
No diffs. |
One The overall design rule I tried to enforce here is "keep detector-dependence out of the algorithms." |
Definitely appreciate this design philosophy! (and the difficulties that come with it...) |
d8c9608
to
61cb5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM
Briefly, what does this PR introduce?
This migrates PhotoMultiplierDigi_factory to JOmniFactory. Couple of points of note:
src/global/digi
now has only headers, so the targetdigi_library
is gone; probably could movePhotoMultiplierDigi_factory
intosrc/factories/digi
for clarity,std::vector<std::pair<double, double>>
for quantum efficiency, so that's disabled in the ParameterRef list (@nathanwbrei OT, but having to specify a variable name for theseParameterRef
seems useless; can we stick them in a container?),this
and callsm_RichGeoSvc().GetReadoutGeo(GetPluginName())
which in turn has acall_once
is janky (but not a change from previous practice...):m_RichGeoSvc()
is implicitly modifying the service withcall_once
(and apparently allowed to; @nathanwbrei can JANA enforce immutability of services?)GetReadoutGeo()
first gets thecall_once
flag; that seems dangerous. Putting both PhotoMultiplierDigi_factories in the same plugin doesn't seem like it would be possible. The RichGeo likely needs to be able to support more than one ReadoutGeo and initialize them on demand. It probably needs to fill a map by detector name (not plugin name), with a map ofcall_once
flags or so. @c-dilks any thoughts on where you were going with that?I think for now this maintains the status-quo, but we need to find a better solution to this in a different PR that reworks this...
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.