Skip to content

Commit

Permalink
fix(ci): compress install and build artifact with zstd (#1152)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
After finding in #1124 that compression does matter, we might as well
use the best modern compression currently available to evaluate if it
does any better than gz. Since it does (comment below) we apply this to
both install and build artifacts.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
  • Loading branch information
wdconinc authored Nov 25, 2023
1 parent 2bcb66c commit 3ef2061
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions .github/workflows/linux-eic-shell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,21 +104,21 @@ jobs:
run: |
export LD_LIBRARY_PATH=$PWD/install/lib:$LD_LIBRARY_PATH
ctest --test-dir build -V
- name: Archive install directory
run: tar -cf install.tar install/
- name: Compress install directory
run: tar -caf install.tar.zst install/
- name: Upload install directory
uses: actions/upload-artifact@v3
with:
name: install-${{ matrix.CC }}-eic-shell-${{ matrix.CMAKE_BUILD_TYPE }}
path: install.tar
path: install.tar.zst
if-no-files-found: error
- name: Compress build directory
run: tar -czf build.tar.gz build/
run: tar -caf build.tar.zst build/
- name: Upload build directory
uses: actions/upload-artifact@v3
with:
name: build-${{ matrix.CC }}-eic-shell-${{ matrix.CMAKE_BUILD_TYPE }}
path: build.tar.gz
path: build.tar.zst
if-no-files-found: error

clang-tidy-iwyu:
Expand All @@ -136,7 +136,7 @@ jobs:
name: build-clang-eic-shell-Debug
path: .
- name: Uncompress build artifact
run: tar -zxf build.tar.gz
run: tar -xaf build.tar.zst
- name: Run clang-tidy on changed files
uses: eic/run-cvmfs-osg-eic-shell@main
if: ${{ github.event_name == 'pull_request' }}
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
name: build-clang-eic-shell-Debug
path: .
- name: Uncompress build artifact
run: tar -zxf build.tar.gz
run: tar -xaf build.tar.zst
- run: sudo apt-get update
- run: sudo apt-get install -y llvm-15 jq
- name: llvm-cov
Expand Down Expand Up @@ -378,7 +378,7 @@ jobs:
with:
name: install-${{ matrix.CC }}-eic-shell-Release
- name: Unarchive install directory
run: tar -xf install.tar
run: tar -xaf install.tar.zst
- name: Download simulation input
uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -438,7 +438,7 @@ jobs:
with:
name: install-${{ matrix.CC }}-eic-shell-Release
- name: Unarchive install directory
run: tar -xf install.tar
run: tar -xaf install.tar.zst
- uses: actions/download-artifact@v3
with:
name: sim_${{ matrix.particle }}_1GeV_20GeV_${{ matrix.detector_config }}.edm4hep.root
Expand Down Expand Up @@ -485,7 +485,7 @@ jobs:
with:
name: install-${{ matrix.CC }}-eic-shell-Release
- name: Unarchive install directory
run: tar -xf install.tar
run: tar -xaf install.tar.zst
- uses: actions/download-artifact@v3
with:
name: sim_${{ matrix.particle }}_1GeV_20GeV_${{ matrix.detector_config }}.edm4hep.root
Expand Down Expand Up @@ -526,7 +526,7 @@ jobs:
with:
name: install-${{ matrix.CC }}-eic-shell-Release
- name: Uncompress install directory
run: tar -xf install.tar
run: tar -xaf install.tar.zst
- uses: actions/download-artifact@v3
with:
name: sim_${{ matrix.particle }}_1GeV_20GeV_${{ matrix.detector_config }}.edm4hep.root
Expand Down Expand Up @@ -645,7 +645,7 @@ jobs:
with:
name: install-${{ matrix.CC }}-eic-shell-Release
- name: Unarchive install directory
run: tar -xf install.tar
run: tar -xaf install.tar.zst
- uses: actions/download-artifact@v3
with:
name: sim_${{ matrix.particle }}_EcalLumiSpec_${{ matrix.detector_config }}.edm4hep.root
Expand Down Expand Up @@ -700,7 +700,7 @@ jobs:
with:
name: install-${{ matrix.CC }}-eic-shell-Release
- name: Unarchive install directory
run: tar -xf install.tar
run: tar -xaf install.tar.zst
- uses: actions/download-artifact@v3
with:
name: sim_dis_${{ matrix.beam }}_minQ2=${{ matrix.minq2 }}_${{ matrix.detector_config }}.edm4hep.root
Expand Down

0 comments on commit 3ef2061

Please sign in to comment.