feat: deprecate simID and recID accessors #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
force-pushed
the
deprecate-simID-recID
branch
from
221407e to
8dff4ff
Compare
|
seems that recID and simID are still actively used here https://github.com/eic/EICrecon/blob/32070b472cad3bdc10f957e1ff43273c56118a80/src/algorithms/calorimetry/EnergyPositionClusterMerger.h#L154. Would that be a problem? |
|
Deprecation is in part a strategy to manifest residual usage. |
ShujieL
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This deprecates the
simIDandrecIDfields of the associations, instead of just simply removing them entirely in #51.See backwards compatibility note below.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
This will still break ROOT scripts that directly access the data storage layer (leafs in ROOT tree) in the ROOT files. In podio context that's a private interface, but many in EIC have been treating it as public.
Does this PR change default behavior?
Yes,
simIDandrecIDwill not be stored.