Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract model params from supported models #92

Merged
merged 73 commits into from
Aug 7, 2024
Merged

Extract model params from supported models #92

merged 73 commits into from
Aug 7, 2024

Conversation

egouldo
Copy link
Owner

@egouldo egouldo commented Aug 7, 2024

egouldo and others added 30 commits July 29, 2024 21:09
- rm duplicate fn added to fit_metafor_mv on other branch
- update roxygen blocks
- `mv` refers to the `rma.mv` function which aso fits models with random-effects / mixed effects models, not just multivariate models (and fit_MA_mv() actually does the former, not the latter).
- supply filter variables
- supply explicit NULL in yi application
- #29 extract and parse symbols to group_by
- add check that expected columns exist in input data
- Output current grouping variables
(was resulting in tibbles in list-column rather than list-column of models)
- was causing problems for `map_if()` predicate check expressions in `make_viz()`
- takes 1 minute to run locally, yippeeee!!!! remember when it used to take 10 mins!!!!
egouldo added 23 commits August 7, 2024 22:51
…ould draw from input arguments not package data
- snapshot after crew::
- only needed for running targets pipeline, hence does not need to be in depends.
- run on any model supported by parameters::
- deals with the problem of the list-col being named for only some rows by wrapping the .p in possibly() (otherwise there's a mismatch in depth)
@egouldo egouldo added this to the Respond Reviewer Comments milestone Aug 7, 2024
@egouldo egouldo linked an issue Aug 7, 2024 that may be closed by this pull request
@egouldo egouldo added the bug an unexpected problem or unintended behavior label Aug 7, 2024
@egouldo egouldo self-assigned this Aug 7, 2024
@egouldo egouldo merged commit e0a5835 into main Aug 7, 2024
1 check failed
@egouldo egouldo deleted the 67-model-params branch August 7, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*ALL* model_params outputs return NA....
1 participant