feat: update header for sidebar #69
Merged
+21
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/update_header
branch
from
b8e6dfb to
ad8de19
Compare
varshamenon4
approved these changes
Dec 5, 2024
| @@ -116,7 +111,7 @@ const Sidebar = ({ | |||
| alt="close" | |||
| aria-label="close" | |||
| variant="primary" | |||
| invertColors={!disclosureAcknowledged} | |||
| invertColors | |||
| @@ -36,7 +36,7 @@ const courseId = 'course-v1:edX+DemoX+Demo_Course'; | |||
| const unitId = 'block-v1:edX+DemoX+Demo_Course+type@unit+block@unit1'; | |||
|
|
|||
| const assertSidebarElementsNotInDOM = () => { | |||
| expect(screen.queryByTestId('heading', { name: 'Hi, I\'m Xpert!' })).not.toBeInTheDocument(); | |||
| expect(screen.queryByTestId('sidebar-xpert-header')).not.toBeInTheDocument(); | |||
There was a problem hiding this comment.
Nice! I like that you made the test id more descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMO-571
This pull request includes changes to the
Sidebarcomponent to update its styling and improve its functionality. The most important changes include adding a new header with a logo, modifying the separator styling, and updating the corresponding tests.Old sidebar header:
New sidebar h
eader: