style: fix modal size with large number of exams #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
force-pushed
the
zhancock/add-modal-fix
branch
from
d760fe4 to
045a2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMO-451
Fixes the overflow with a large number of exams. Scrolling is still a bit rough since you can't scroll the parent window with the pointer over the modal background and need to move it to the side. You'd need to do that if part of the content such as the submit button is below the fold. I plan to follow up with a PR in edx-platform to shorten this iframe so it generally doesn't go beyond screen limits and the only scrolling needed is in the iframe itself (which this PR will now allow).
With just this fix alone:
scrolled to bottom
