Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable reference syntax #12

Merged
merged 3 commits into from
May 21, 2024

Conversation

connorhaugh
Copy link

Configuration Pull Request

Per: https://stackoverflow.com/questions/4181703/how-to-concatenate-string-variables-in-bash
We need the ${} to reference variables and avoid ambiguity


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.
  • Think about how this change will affect Open edX operators and update the wiki page for the next Open edX release if needed

Copy link
Member

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@connorhaugh connorhaugh merged commit db93f80 into master May 21, 2024
4 checks passed
@connorhaugh connorhaugh deleted the feat--add-dd-trace-to-edxapp-workers-redux branch May 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants