Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add device-opc-ua documentation #1324

Closed
wants to merge 1 commit into from

Conversation

jiekechoo
Copy link
Member

@jiekechoo jiekechoo commented Dec 15, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

Sorry, something went wrong.

@lenny-goodell lenny-goodell marked this pull request as draft December 15, 2023 15:53
@lenny-goodell
Copy link
Member

@jiekechoo , the OPCUA device service in holding is NOT a support EdgeX service so I have put this PR in draft. I assume your intention is to rework that service and propose it be accepted into EdgeX?

@jiekechoo
Copy link
Member Author

@lenny-intel

the OPCUA device service in holding is NOT a support EdgeX service so I have put this PR in draft.

Ok,it's all right.

I assume your intention is to rework that service and propose it be accepted into EdgeX?

Yes. I'll contribute several device services, I believe that more users will need them.

@FelixTing
Copy link
Member

@jiekechoo I noticed that the README mentions the limitation that this device service is currently limited to a single device instance. Could you also include this note in the documentation for consistency? It would be helpful for users.

@jumpingliu
Copy link
Contributor

Hi @jiekechoo, would you mind addressing the requested changes on GitHub when you get a chance? thanks

@jiekechoo jiekechoo marked this pull request as ready for review February 21, 2025 14:25
@jiekechoo
Copy link
Member Author

@jiekechoo I noticed that the README mentions the limitation that this device service is currently limited to a single device instance. Could you also include this note in the documentation for consistency? It would be helpful for users.

It's fixed already.

Signed-off-by: Jieke Choo <jiekechoo@yiqisoft.cn>
@jiekechoo jiekechoo changed the title feat: Add device-opcua documentation feat: Add device-opc-ua documentation Feb 21, 2025
@jiekechoo jiekechoo closed this Feb 21, 2025
@jiekechoo jiekechoo deleted the device-opcua branch February 21, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants