e2e: add ability to wait for different conditions in kubeclient.WaitFor
#888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miampf
force-pushed
the
miampf/kubeclient/improve-waiting
branch
from
2a42396 to
843da8f
Compare
miampf
requested review from
Freax13 and
katexochen
and removed request for
katexochen
Freax13
reviewed
Sep 25, 2024
miampf
force-pushed
the
miampf/kubeclient/improve-waiting
branch
2 times, most recently
from
c53c6c7 to
4b7a266
Compare
Freax13
approved these changes
Sep 27, 2024
start rewrite to avoid code duplication prototyped functionality of functions
merge Running and InitContainersRunning together better comment changed back lines that got changed unintentionally add back build tags
miampf
force-pushed
the
miampf/kubeclient/improve-waiting
branch
from
45014d5 to
4a7fbdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to wait for different conditions using the
kubeclient.WaitForfunction. Supported conditions are:Ready: This has the same functionality as the oldkubeclient.WaitFor.Running: Waits until all containers of all pods of the corresponding resource are running or until the context timeouts.InitContainersRunning: Same asRunning, but only check the initial containers of all pods of the corresponding resource.Added,Bookmark,Deleted,Modified: Those are synonymous for waiting on the correspondingwatch.EventTypefound ink8s.io/apimachinery/pkg/watch.