work on bare-metal SNP support in node-installer #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
requested changes
Jul 15, 2024
katexochen
requested changes
Jul 15, 2024
Nodes on other platforms (notably bare-metal ones) obviously won't have azure-specific annotations.
Previously we accidentally replaced the whole config with that one line. We only intended the replace the line.
Freax13
force-pushed
the
tom/qemu-snp-baremetal
branch
from
db40486 to
fb276a5
Compare
Freax13
force-pushed
the
tom/qemu-snp-baremetal
branch
from
fb276a5 to
fecf002
Compare
katexochen
requested changes
Jul 16, 2024
This fixes a couple of bugs: 1. Executing the node-installer twice no longer results in the sections being added more than once. 2. We no longer emit empty sections that may already exist in the file. 3. We emit the correct tables names (previously we were missing the `plugins.` prefix. Co-authored-by: Paul Meyer <[email protected]>
Freax13
force-pushed
the
tom/qemu-snp-baremetal
branch
from
fecf002 to
bc3b830
Compare
QEMU looks for these files when booting the VM and fails if it can't find them.
Our fork has some fixes for the stepping issues with Genoa.
The hashes were incorrect. My guess is that we forgot to update them when updating kata and didn't notice because we're not actually using those files right now.
Freax13
force-pushed
the
tom/qemu-snp-baremetal
branch
from
bc3b830 to
29d88ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first required steps for bare-metal SNP support and some drive-by fixes for the node-installer.