Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: inject contrast-secrets mount into initcontainers #1183

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Jan 23, 2025

The Contrast CLI injects a volumeMount for Contrast secrets (TLS certificates and workload secrets) into application containers. This was used to be done for regular containers only, not for initcontainers.

However, many use cases for initcontainers involve the Contrast secrets - our own demos are a good example. Therefore, we add support for injecting the mount into initcontainers.

@burgerdev burgerdev added the bug fix Fixing a user facing bug label Jan 23, 2025
@burgerdev burgerdev marked this pull request as ready for review January 23, 2025 16:24
@burgerdev burgerdev requested a review from katexochen January 23, 2025 16:25
@katexochen katexochen added this to the v1.4.0 milestone Jan 24, 2025
@burgerdev burgerdev merged commit e43ff40 into main Jan 24, 2025
14 checks passed
@burgerdev burgerdev deleted the burgerdev/inject-init branch January 24, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a user facing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants