-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just: match both yaml and yml #1147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, doesn't this result in a glob failure if there's either no yml
or no yaml
?
@burgerdev no, you can test this by: $ ll *.{yml,yaml}
"*.yml": No such file or directory (os error 2)
"*.yaml": No such file or directory (os error 2)
$ ll *.yml
"*.yml": No such file or directory (os error 2) |
That fails for me:
|
Oh, i missed the either. Do you have a suggestion on how to glob this instead? |
We could set |
This fixes a little papercut I ran into when working with the `.custom` directory, where I wondered why my files weren't included. Turned out we only match against `.yml` while I used `.yaml`. This makes it so both endings are valid and included.
0d210ec
to
3a219cf
Compare
Tested this with |
Please don't overengineer this. We use .yml by convention. |
This fixes a little papercut I ran into when working with the
.custom
directory, where I wondered why my files weren't included. Turned out we only match against.yml
while I used.yaml
. This makes it so both endings are valid and included.