Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.2] service-mesh: test readiness with exec probe #1144

Closed
wants to merge 1 commit into from

Conversation

edgelessci
Copy link
Contributor

Backport of #1142 to release/v1.2.

Original description:


The startup probe for the mesh proxy is redirected onto the same port, causing Envoy to open connections to itself recursively. Unfortunately, this is not visible in the Envoy logs - I only discovered this condition while working on a custom proxy implementation.

Things that are still unclear:

  • There is some race condition that causes the redirection loop to only occur ~50% of the time.
  • Switching on debug logging makes this condition much rarer.
  • Exempting the TPROXY ports with iptables should make the SO_ORIGINAL_DST lookup fail, but the loop happens nonetheless.
  • The issue reproduces with opening and holding a single connection, while opening another, but not with just one connection.

Tests:

@edgelessci edgelessci added this to the v1.3.0 milestone Jan 13, 2025
@edgelessci edgelessci added the bug fix Fixing a user facing bug label Jan 13, 2025
@katexochen katexochen removed this from the v1.3.0 milestone Jan 15, 2025
@katexochen katexochen closed this Jan 17, 2025
@katexochen katexochen deleted the backport-1142-to-release/v1.2 branch January 17, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a user facing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants