manifest: allow disabling the workload secret #1130
Merged
+45
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
changed the title
burgerdev
force-pushed
the
burgerdev/no-empty-secrets
branch
from
7158a33 to
58339fa
Compare
burgerdev
changed the title
katexochen
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be reasons for disabling the workload secret, for example the principle of least privilege. As of today, setting
WorkloadSecretIDto an empty string (or removing it from the manifest) causes a pod initialization failure. This PR changes the workload secret handling such that an empty string disables the workload secret (it won't be derived by the coordinator and won't be written by the initializer).