packages/kata-image: specify correct fs-type in error message #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used `stat` as a heuristic to detect the filesystem type, which is sub-optimal, as it will report `ext2/ext3` on `ext4` filesystems, leaving the reader of the error message in incertainty about the error. Switch to `df`, which is a better heuristic. \[1\] \[1\]: https://unix.stackexchange.com/questions/256920/stat-f-show-a-ext4-file-system-type-as-ext2-ext3/274030#274030
burgerdev
reviewed
Dec 4, 2024
| @@ -155,7 +155,7 @@ let | |||
| runHook preBuild | |||
|
|
|||
| # Check if filesystem is ext.* | |||
| fstype=$(stat -f -c %T .) | |||
| fstype=$(df -T . | awk '{print $2}' | tail -n 1) | |||
There was a problem hiding this comment.
As far as I understand, the issue with stat is that the superblock magic of ext4 is the same as for ext2 and ext3, so it lacks details to understand the diff and nobody bothered to upgrade the type string (or maybe it needs to stay like that for backwards compatibility). For our purposes, this does not really matter, since all ext* are affected. Could we just replace the $fstype in the error message with a literal ext2/ext3/ext4?
There was a problem hiding this comment.
I just thought that this will be superfluous with #1019 anyways. Closing this one in favor of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
statas a heuristic to detect the filesystem type, which is sub-optimal, as it will reportext2/ext3onext4filesystems, leaving the reader of the error message in incertainty about the error. Switch todf, which is a better heuristic. [1][1]: https://unix.stackexchange.com/questions/256920/stat-f-show-a-ext4-file-system-type-as-ext2-ext3/274030#274030