Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: add log messages for handshake failures #1010

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

burgerdev
Copy link
Contributor

The gRPC stack does not log errors from the Credentials, and if the TLS session is not established the error won't be sent back to the client, either. With this commit, the error shows up at least in the server logs.

@burgerdev burgerdev requested a review from katexochen November 18, 2024 11:36
@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Nov 18, 2024
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev merged commit 385aa57 into main Nov 18, 2024
9 of 10 checks passed
@burgerdev burgerdev deleted the burgerdev/no-manifest branch November 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants