rpm/el8 #13
rpm/el8 #13
Conversation
This commit fix syntax error related to the migration of python2 to python3
This allows to change #!/usr/bin/python interpreter to #!/usr/bin/python3 (or python2) explicitly to fix build errors
hpcstats.spec
Outdated
|
|
||
| %files -n hpcstats-utils | ||
| %config %{_datadir}/%{name}/bin/encode-password | ||
| %config %{_datadir}/%{name}/bin/sync-hpcstats-slurm-job-accounts |
There was a problem hiding this comment.
I see 3 scripts in the %description but only two scripts in the %files ?
There was a problem hiding this comment.
That’s a very good point.
From what I understand, the scripts in the %description section are mainly managed by the main program HPCStatsImporter.
What is described in the %files section does' nt necessarily reflect all scripts of the %description as in the case of the encode-password
There was a problem hiding this comment.
The description and the content should match.
else it doesn't make sense?
hpcstats.spec
Outdated
| %doc README.md | ||
| %{python3_sitelib}/HPCStats/* | ||
| %{python3_sitelib}/*%{name}*.egg-info | ||
| %config %{_bindir}/hpcstats |
There was a problem hiding this comment.
%{_bindir} as %config seems dubious to me?
hpcstats.spec
Outdated
| install -d %{buildroot}%{_datadir}/%{name} | ||
| install -d %{buildroot}%{_sysconfdir}/%{name} | ||
| install -d %{buildroot}%{_datadir}/%{name}/bin | ||
| install -d %{buildroot}/%{_datadir}/%{name}/db |
There was a problem hiding this comment.
general "style" comment (that is not worth fixing overall imho):
choose if you want to append a / between the folder variables or not.
ie: %{buildroot}/%{_datadir} or %{buildroot}%{_datadir}
It allows also to set the umask to 002
No description provided.