Merge branch 'release/0.7'

edbizarro · Dec 29, 2016 · db86908 · db86908
2 parents b30df77 + 35341fc
commit db86908
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/src/Providers/LaravelFacebookServiceProvider.php b/src/Providers/LaravelFacebookServiceProvider.php
@@ -44,20 +44,18 @@ public function boot()
     public function register()
     {
         $this->app->bind(LaravelFacebookAdsContract::class, function ($app) {
-            return $this->createInstance($app);
+            return $this->createInstance();
         });
 
         $this->app->singleton('facebook-ads', function ($app) {
-            return $this->createInstance($app);
+            return $this->createInstance();
         });
     }
 
     /**
-     * @param $app
-     *
      * @return FacebookAds
      */
-    protected function createInstance($app)
+    protected function createInstance()
     {
         return new FacebookAds(
             (new AdAccounts()),

diff --git a/src/Services/AdAccounts.php b/src/Services/AdAccounts.php
@@ -2,10 +2,10 @@
 
 namespace Edbizarro\LaravelFacebookAds\Services;
 
-use FacebookAds\Object\AdUser;
 use FacebookAds\Object\AdAccount;
-use Illuminate\Support\Collection;
 use FacebookAds\Object\AdAccountUser;
+use FacebookAds\Object\AdUser;
+use Illuminate\Support\Collection;
 
 /**
  * Class AdAccounts.
@@ -53,7 +53,7 @@ public function getAds($accountId, $fields = [])
      *
      * @deprecated use getAccountUser instead
      */
-    private function getUser($userId = 'me')
+    protected function getUser($userId = 'me')
     {
         return new AdUser($userId);
     }
@@ -63,7 +63,7 @@ private function getUser($userId = 'me')
      *
      * @return AdAccountUser
      */
-    private function getAccountUser($accountUserId = 'me')
+    protected function getAccountUser($accountUserId = 'me')
     {
         return new AdAccountUser($accountUserId);
     }

diff --git a/src/Services/Insights/AdInsights.php b/src/Services/Insights/AdInsights.php
@@ -21,8 +21,8 @@ public function getInsights($objectId, $params = [])
         $fields = $params['fields'];
         unset($params['fields']);
 
-        $ad = new Ad($objectId);
-        $insights = $ad->getInsights($fields, $params);
+        $adObject = new Ad($objectId);
+        $insights = $adObject->getInsights($fields, $params);
 
         return $this->response($insights);
     }