Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/metk 116 negative levelist #38

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

mcakircali
Copy link
Contributor

levelist type: adds tests and support for range expansion when by < 0

@FussyDuck
Copy link

FussyDuck commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c00605a) 56.48% compared to head (efde4c9) 56.76%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #38      +/-   ##
===========================================
+ Coverage    56.48%   56.76%   +0.28%     
===========================================
  Files           96       97       +1     
  Lines         5600     5630      +30     
===========================================
+ Hits          3163     3196      +33     
+ Misses        2437     2434       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Private downstream CI failed.
Workflow name: private downstream ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/6944551779.

Copy link

Private downstream CI failed.
Workflow name: private downstream ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/6944953185.

Copy link

github-actions bot commented Dec 4, 2023

Private downstream CI succeeded.
Workflow name: private downstream ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/7086324060.

1 similar comment
Copy link

github-actions bot commented Dec 4, 2023

Private downstream CI succeeded.
Workflow name: private downstream ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/7086324060.

@simondsmart
Copy link
Contributor

Looks good :-)

@simondsmart simondsmart merged commit 245bebf into develop Dec 4, 2023
60 checks passed
@simondsmart simondsmart deleted the feature/METK-116_negativeLevelist branch December 4, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants