Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed change to FDB callback signature (const FieldLocation) #13

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ChrisspyB
Copy link
Member

No description provided.

@FussyDuck
Copy link

FussyDuck commented Sep 16, 2024

CLA assistant check
All committers have signed the CLA.

@ChrisspyB
Copy link
Member Author

Waiting for corresponding change to be merged in FDB

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (7c5a3fe) to head (07988f1).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
src/gribjump/info/InfoAggregator.cc 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #13   +/-   ##
========================================
  Coverage    57.24%   57.24%           
========================================
  Files           78       78           
  Lines         3892     3892           
  Branches       440      440           
========================================
  Hits          2228     2228           
  Misses        1664     1664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisspyB ChrisspyB marked this pull request as ready for review September 16, 2024 14:20
@ChrisspyB ChrisspyB merged commit 06bc227 into develop Sep 16, 2024
99 checks passed
@ChrisspyB ChrisspyB deleted the feature/callbackSignature branch November 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants