Feature/archive callback #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24 +/- ##
===========================================
+ Coverage 63.36% 63.49% +0.13%
===========================================
Files 235 236 +1
Lines 13343 13391 +48
Branches 1288 1291 +3
===========================================
+ Hits 8455 8503 +48
Misses 4888 4888 ☔ View full report in Codecov by Sentry. |
ChrisspyB
commented
Jun 10, 2024
ChrisspyB
commented
Jun 10, 2024
simondsmart
requested changes
Jun 12, 2024
|
We decided to not return a key from the archive method, and also decided not to bother propgating this change to the C API just yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API for registering a callback function
foo(key, location), to be called upon archiving to the Store.