addressed PR + fix toc async read

ecmwf · Nov 29, 2024 · e5f2ace · e5f2ace
1 parent 99d130a
commit e5f2ace
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/fdb5/io/LustreSettings.cc b/src/fdb5/io/LustreSettings.cc
@@ -38,7 +38,7 @@ bool fdb5LustreapiSupported() {
 #endif
 }
 
-int fdb5LustreapiFileCreate(eckit::PathName path, LustreStripe stripe) {
+int fdb5LustreapiFileCreate(const eckit::PathName& path, LustreStripe stripe) {
 
 #if defined(fdb5_HAVE_LUSTRE)
 

diff --git a/src/fdb5/io/LustreSettings.h b/src/fdb5/io/LustreSettings.h
@@ -43,7 +43,7 @@ LustreStripe stripeDataLustreSettings();
 
 //----------------------------------------------------------------------------------------------------------------------
 
-int fdb5LustreapiFileCreate(eckit::PathName path, LustreStripe stripe);
+int fdb5LustreapiFileCreate(const eckit::PathName& path, LustreStripe stripe);
 
 bool fdb5LustreapiSupported();
 

diff --git a/src/fdb5/toc/TocHandler.cc b/src/fdb5/toc/TocHandler.cc
@@ -725,7 +725,7 @@ class SubtocPreloader {
                 int fd;
                 SYSCALL2((fd = ::open(path.localPath(), iomode)), path);
                 closers.emplace_back(AutoFDCloser{fd});
-                eckit::Length tocSize = 2*1024*1024;
+                eckit::Length tocSize = path.size();
 
                 aiocb& aio(aiocbs[i]);
                 zero(aio);
@@ -802,9 +802,8 @@ class SubtocPreloader {
             }
         }
 #else
-    NOTIMP
+    NOTIMP;
 #endif // eckit_HAVE_AIO
-
         return std::move(subTocReadCache_);
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -38,7 +38,7 @@ bool fdb5LustreapiSupported() { @@
     #endif
     }
-    int fdb5LustreapiFileCreate(eckit::PathName path, LustreStripe stripe) {
+    int fdb5LustreapiFileCreate(const eckit::PathName& path, LustreStripe stripe) {
     #if defined(fdb5_HAVE_LUSTRE)
@@ Expand Down @@