#6: Implemented DataHandler class and extract/remove/namelist #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage ? 78.15%
=======================================
Files ? 22
Lines ? 1927
Branches ? 0
=======================================
Hits ? 1506
Misses ? 421
Partials ? 0 ☔ View full report in Codecov by Sentry. |
reuterbal
requested changes
Jan 9, 2025
mlange05
reviewed
Jan 10, 2025
There was a problem hiding this comment.
This looks great, and aside from the marked docstrings the design is very neat. I agree with all that was said before and look forward to seeing the actual "pipelines" in action.
Will mark only as comment for now, until all of B.'s points are addressed, but looks good to me otherwise.
johannesbulin
added a commit
to johannesbulin/ifsbench
that referenced
this pull request
Jan 10, 2025
johannesbulin
force-pushed
the
johannesbulin.datahandler.#6
branch
from
65dedfc to
854b655
Compare
reuterbal
approved these changes
Jan 20, 2025
| else: | ||
| self._target_dir = pathlib.Path(target_dir) | ||
|
|
||
| def execute(self, wdir, **kwargs): |
There was a problem hiding this comment.
Not sure if it works like this but fine with keeping it like this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See issue #6)
Added support for data pipelines to
ifsbench. The main feature is aDataHandlerbase class that can perform a given action on a working directory. Currently I've implemented:RenameHandler- for moving/renaming/copying files, using regular expressions.NamelistHandler- for modifying namelists.ExtractHandler- for extracting archives.Talking points / request for feedback:
InputFileconcept that we've used before (with file hashes and other things). If you think that this should be included, I'd be happy about some suggestions.RenameHandler.RenameModefor example). It's a bit clunky to write but I haven't come up with a better solution.