Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise with CY49R1.0 #60

Conversation

samhatfield
Copy link
Collaborator

A number of commits were made in the past year or two to the contrib/ectrans directory of ifs-source. Some of these have already been cherry picked to develop here. This commit brings over the remaining differences.

Note that the MétéoFrance copyright statements are not always the same between this branch and contrib/ectrans. I have ignored differences of the form

! (C) Copyright 2000- Meteo-France. -> ! (C) Copyright 2013- Meteo-France.

Copy link
Collaborator

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samhatfield for taking care of this! Much appreciated.

@reuterbal
Copy link
Contributor

Not sure I'm overlooking something but I can't seem to find the matching deallocate for ZGTF_HEAP. Just wondering if this isn't a memory leak?

@samhatfield
Copy link
Collaborator Author

I will check this hasn't been left behind in my commit.

@samhatfield
Copy link
Collaborator Author

All ft*_ctl*_mod.F90 files are in sync so there's no DEALLOCATE in the original either. Is it not the case that ZGTF_HEAP will be automatically deallocated when it goes out of scope?

@wdeconinck
Copy link
Collaborator

All ft*_ctl*_mod.F90 files are in sync so there's no DEALLOCATE in the original either. Is it not the case that ZGTF_HEAP will be automatically deallocated when it goes out of scope?

Indeed anything like this:

REAL(KIND=JPRB),TARGET, ALLOCATABLE :: ZGTF_HEAP(:,:)

when allocated will automatically be deallocated. That is a difference between POINTER and ALLOCATABLE attribute.

@reuterbal
Copy link
Contributor

Right, sorry, I overlooked this!

@wdeconinck wdeconinck merged commit 0f9e946 into ecmwf-ifs:develop Feb 13, 2024
11 checks passed
@samhatfield samhatfield deleted the samhatfield/sync_with_CY49R1.0_contrib branch February 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants