Make CPU/GPU GSTATS regions consistent #59
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPU porting of ecTrans introduced some new GSTATS regions. The following are now reported in the GSTATS summary of NODE.001_01 in the IFS when using ecTrans GPU mode:
410, 411, 412, 413, 430, 431, 440, 441
These are currently unlabelled so show up as rather anonymous in the profile:
So the question is, which of these would we like to keep (probably some were simply for debugging), and of those which should be copied also the CPU version.
I would argue that 440 (DIR_TRANS) and 441 (INV_TRANS) are very useful and should be kept - see first commit. The others are not so important so could probably be deleted.