Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-hpc CI #208

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix build-hpc CI #208

merged 1 commit into from
Feb 5, 2025

Conversation

samhatfield
Copy link
Collaborator

I will document this further later.

@samhatfield samhatfield force-pushed the fix_build-hpc_ci branch 3 times, most recently from dd8a536 to 8e7a487 Compare February 5, 2025 14:13
@samhatfield
Copy link
Collaborator Author

samhatfield commented Feb 5, 2025

From the commit:

Without this, actions triggered by pull requests opened from branches in forks always check out the target branch rather than the source branch.

This pull request therefore fixes the behaviour of the CI suite for PRs opened from forks, and allows proper testing of those PRs before they are merged.

@samhatfield samhatfield requested a review from reuterbal February 5, 2025 14:14
@samhatfield
Copy link
Collaborator Author

Note: inspired by ecmwf-ifs/field_api@f8b43b5. Many thanks @awnawab!

Without this, actions triggered by pull requests opened from branches in forks always check out the target branch rather than the source branch.
@samhatfield samhatfield merged commit 5eb8d51 into develop Feb 5, 2025
24 checks passed
@samhatfield samhatfield deleted the fix_build-hpc_ci branch February 5, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants