Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single precision and architecture files for SYCL variants #92

Merged
merged 19 commits into from
Aug 23, 2024
Merged

Single precision and architecture files for SYCL variants #92

merged 19 commits into from
Aug 23, 2024

Conversation

MichaelSt98
Copy link
Contributor

SYCL SP tested on AC

via e.g. cloudsc-bundle build --clean --build-dir=build-sp-sycl-serialbox --arch=arch/ecmwf/hpc2020/intel-sycl/2021.4.0 --with-sycl --with-serialbox --single-precision --cloudsc-cpp-math=C ...

MichaelSt98 and others added 16 commits February 29, 2024 10:09
@MichaelSt98
remove out_stream and fix load_state
a07915c
@MichaelSt98
adding SP SYCL
36459a7
@MichaelSt98
SYCL SP (in a separate directory)
858a390
@MichaelSt98
SYCL SP math function macros
c4947d9
@MichaelSt98
SYCL DP math function(s) via macro(s)
06107c1
@MichaelSt98
SYCL SP math function(s) via macro(s)
7c1c27f
@MichaelSt98
arch/env file for 'dawn' in cambridge (to compile SYCL variants)
283e0c7
@MichaelSt98
HDF5 support for SYCL SP
f5f4578
@MichaelSt98
SYCL DP introduce: 'intel::reqd_sub_group_size(16)' for kernel launch
2b4f6fc
@MichaelSt98
SYCL SP introduce: 'intel::reqd_sub_group_size(16)' for kernel launch
4848f87
@MichaelSt98
Math library/function selection via '--cloudsc-math=C|STD|SYCL'
4f604b0
@MichaelSt98
Add STD math function calls (in addition to C and SYCL)
85c8643
@reuterbal
Update DAWN architectures
eeeefbf
@reuterbal
Enable writing compile commands JSON
78a2a27
@reuterbal
Fixes to the SYCL CMake
0e6c9c0
@MichaelSt98
single precision SYCL (via preprocessor macro(s))
c4db928
@MichaelSt98 MichaelSt98 requested a review from reuterbal July 18, 2024 09:40
@reuterbal reuterbal changed the title SYCL SP Single precision and architecture files for SYCL variants Jul 19, 2024
reuterbal
reuterbal requested changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks very good and confirmed working with offloading on AC.

I've left a few minor comments, and it would be good to fail gracefully for unsupported test case dimensions (and change the ctest so that it is valid).

src/cloudsc_sycl/cloudsc/cloudsc_validate.cpp Outdated Show resolved Hide resolved
src/cloudsc_sycl/cloudsc/cloudsc_validate.old Outdated Show resolved Hide resolved
src/cloudsc_sycl/cloudsc/dtype.h Outdated Show resolved Hide resolved
src/cloudsc_sycl/cloudsc/dtype.h Show resolved Hide resolved
src/cloudsc_sycl/cloudsc/load_state.cpp Show resolved Hide resolved
src/cloudsc_sycl/cloudsc/load_state.cpp Outdated Show resolved Hide resolved
bundle.yml Show resolved Hide resolved
reuterbal
reuterbal approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the requested changes! Looks all good to me now and confirmed to work locally.

@reuterbal reuterbal merged commit e9b3af7 into develop Aug 23, 2024
18 checks passed
@reuterbal reuterbal deleted the nams-sycl-sp-single-dir branch August 23, 2024 14:59
@reuterbal reuterbal mentioned this pull request Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reuterbal reuterbal reuterbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelSt98 @reuterbal