Test apps with no paths #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Azquelt
requested changes
May 30, 2024
...c/main/java/org/eclipse/microprofile/openapi/reader/MyOASModelReaderForJustComponentApp.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/microprofile/openapi/reader/MyOASModelReaderForJustWebHookApp.java
Outdated
Show resolved
Hide resolved
benjamin-confino
force-pushed
the
592-no-paths
branch
from
14a5b0c to
11da26d
Compare
Azquelt
reviewed
May 30, 2024
...src/main/java/org/eclipse/microprofile/openapi/reader/MyOASModelReaderForJustWebHookApp.java
Outdated
Show resolved
Hide resolved
benjamin-confino
force-pushed
the
592-no-paths
branch
from
11da26d to
e74df60
Compare
Azquelt
reviewed
May 31, 2024
| @Test(dataProvider = "formatProvider") | ||
| public void testDocumentCreated(String type) { | ||
| ValidatableResponse vr = callEndpoint(type); | ||
| vr.body("webhooks.blackMarketEvent.get.summary", equalTo("Notifies that a illicit deal has been done")); |
There was a problem hiding this comment.
Does this pass? It looks like it ought to fail. If it is passing then I'm even more worried.
There was a problem hiding this comment.
Good news, it needed fixing to pass.
Azquelt
reviewed
May 31, 2024
Comment on lines
+33
to
+34
| .addAsManifestResource("microprofile-reader-just-component.properties", | ||
| "microprofile-config.properties"); |
There was a problem hiding this comment.
I think this is actually putting the properties file in the wrong place, but the existing tests are also wrong, so I'll raise a new issue for that.
benjamin-confino
force-pushed
the
592-no-paths
branch
from
e74df60 to
d1a6ea8
Compare
Azquelt
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #592
No changes to smallrye were required to pass these tests.