Fix all checkstyle errors #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin-confino
force-pushed
the
checkstyle
branch
from
aa40f03 to
070c572
Compare
|
Can one of the admins verify this patch? |
benjamin-confino
force-pushed
the
checkstyle
branch
from
070c572 to
f4f0126
Compare
|
I've been informed that Microparent will be updated soon, so I'll deliver this later with the new version to avoid all that TCK stuff. |
benjamin-confino
force-pushed
the
checkstyle
branch
from
f4f0126 to
fbcbb6e
Compare
Azquelt
approved these changes
May 28, 2024
| <version>2.8</version> | ||
| <version>2.9-RC1</version> |
There was a problem hiding this comment.
We would need to update this before release.
There was a problem hiding this comment.
Opened #623 so we don't forget to do the update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all checkstyle errors in the repository
I won't blame you if you want to hold off on this until after https://github.com/eclipse/microprofile-parent/pull/82/files is merged and published to avoid the pom.xml changes.