Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Resource::get_best_key #1754

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Feb 4, 2025

Fixes #1755

@wyfo wyfo requested a review from OlivierHecart February 4, 2025 10:49
Copy link

github-actions bot commented Feb 4, 2025

PR missing one of the required labels: {'enhancement', 'documentation', 'dependencies', 'bug', 'new feature', 'internal', 'breaking-change'}

@wyfo wyfo added the bug Something isn't working label Feb 4, 2025
@OlivierHecart OlivierHecart linked an issue Feb 4, 2025 that may be closed by this pull request
@OlivierHecart OlivierHecart merged commit e4ea6f0 into eclipse-zenoh:main Feb 4, 2025
14 of 15 checks passed
@OlivierHecart OlivierHecart deleted the fix/get_best_key branch February 4, 2025 13:38
JEnoch added a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Feb 4, 2025
JEnoch added a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Feb 4, 2025
Yadunund added a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>
Co-authored-by: yuanyuyuan <[email protected]>
Co-authored-by: Yadunund <[email protected]>
mergify bot pushed a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>
Co-authored-by: yuanyuyuan <[email protected]>
Co-authored-by: Yadunund <[email protected]>
(cherry picked from commit d322d6f)
mergify bot pushed a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>
Co-authored-by: yuanyuyuan <[email protected]>
Co-authored-by: Yadunund <[email protected]>
(cherry picked from commit d322d6f)
Yadunund pushed a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>
Co-authored-by: yuanyuyuan <[email protected]>
Co-authored-by: Yadunund <[email protected]>
(cherry picked from commit d322d6f)

Co-authored-by: Julien Enoch <[email protected]>
Yadunund pushed a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>
Co-authored-by: yuanyuyuan <[email protected]>
Co-authored-by: Yadunund <[email protected]>
(cherry picked from commit d322d6f)

Co-authored-by: Julien Enoch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing regression
2 participants