Fixing compilation errors due to json-schema changes. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerrett <[email protected]>
Signed-off-by: Gerrett <[email protected]>
…SING_VALUE. Adding unit tests. Signed-off-by: Gerrett <[email protected]>
pk-work
requested changes
Aug 2, 2024
src/test/java/io/vertx/tests/validation/SchemaValidationExceptionTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/vertx/openapi/validation/SchemaValidationException.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gerrett <[email protected]>
pk-work
approved these changes
Aug 3, 2024
CheesyBoy123
force-pushed
the
fix-main-branch
branch
from
8a0e4d4 to
83ce486
Compare
pk-work
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There were recent changes to vertx-json-schema to provide more indepth error reporting. We are using that now in openapi to better report errors to the user.
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines