Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #36

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Jul 11, 2024

Also make sure that we can run CI for PR from forks and trigger build manually if we like

At https://github.com/5monkeys/cobertura-action it is written:

This action will not currently work when triggered by pull requests from forks, like is common in open source projects. This is because the token for forked pull request workflows does not have write permissions on the target repository.

The only test performed is that CI does not break.

@erikbosch erikbosch force-pushed the erik_build branch 8 times, most recently from dde7d40 to 3167eb2 Compare July 11, 2024 11:34
@erikbosch erikbosch changed the title Make it possible to run workflow manually Update dependencies Jul 11, 2024
Also
- Fix so we can run workflow manually to check if there are regressions
- Make sure workflow also works for PRs from other forks
@erikbosch erikbosch marked this pull request as ready for review July 11, 2024 11:48
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@erikbosch erikbosch requested a review from MP91 July 11, 2024 13:25
Copy link

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikbosch erikbosch merged commit d051cba into eclipse-velocitas:main Jul 12, 2024
3 checks passed
@erikbosch erikbosch deleted the erik_build branch July 12, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants